Skip to content

Moved Azure NSG To Unmockable Integrations#12801

Merged
tomneeman151293 merged 3 commits intomasterfrom
Azure-NSG-Unmock-Integration
May 23, 2021
Merged

Moved Azure NSG To Unmockable Integrations#12801
tomneeman151293 merged 3 commits intomasterfrom
Azure-NSG-Unmock-Integration

Conversation

@tomneeman151293
Copy link
Copy Markdown
Contributor

@tomneeman151293 tomneeman151293 commented May 23, 2021

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

Making Azure NSG integration unmockable in tests.
fixes: https://github.com/demisto/etc/issues/33217

@tomneeman151293
Copy link
Copy Markdown
Contributor Author

@dantavori @ShahafBenYakir
Regarding this test failure fix.
It seemed the mocking mechanism did not work for well for some reason with this integration
After I talked to Jasmin, she told me because this integration works with oAuth 2.0 which operates same as AzureWAF,
means this integration should be unmockable
I moved this integration to be unmockable, and test indeed passes.

@ShahafBenYakir
Copy link
Copy Markdown
Contributor

ShahafBenYakir commented May 23, 2021

Where is the issue this PR fixes?
https://github.com/demisto/etc/issues/33217

@tomneeman151293
Copy link
Copy Markdown
Contributor Author

Added fixes: https://github.com/demisto/etc/issues/33217

@tomneeman151293 tomneeman151293 merged commit 94f74ef into master May 23, 2021
@tomneeman151293 tomneeman151293 deleted the Azure-NSG-Unmock-Integration branch May 23, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants