Skip to content

[ASM] - EXPANDR - 1578#24380

Merged
ilaner merged 50 commits intodemisto:contrib/johnnywilkes_ASM-EXPANDR-1578from
johnnywilkes:ASM-EXPANDR-1578
Feb 15, 2023
Merged

[ASM] - EXPANDR - 1578#24380
ilaner merged 50 commits intodemisto:contrib/johnnywilkes_ASM-EXPANDR-1578from
johnnywilkes:ASM-EXPANDR-1578

Conversation

@johnnywilkes
Copy link
Copy Markdown
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-hq.paloaltonetworks.local/browse/EXPANDR-1578

Description

Remediation Path Rules is a new feature in the Xpanse product with UI elements that allows customers’ to express their preferences about how they address different types of risks in different situations. Content involves a new integration command to pull these rules and an automation to determine is a match was found for the current alert. I have included a short demo in the registration form but will also provide a live one if necessary.

Screenshots

Cortex_ASM_-_Remediation_Path_Rules

Cortex_ASM_-_Decision

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 6, 2023

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Feb 6, 2023
@content-bot content-bot changed the base branch from master to contrib/johnnywilkes_ASM-EXPANDR-1578 February 6, 2023 19:57
@content-bot content-bot requested a review from ilaner February 6, 2023 19:58
@content-bot
Copy link
Copy Markdown
Contributor

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilaner will know he can start review the proposed changes.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Feb 6, 2023
@johnnywilkes
Copy link
Copy Markdown
Contributor Author

@ShirleyDenkberg , just an FYI that I had to update your wording for changed in release notes because it didn't seem to fit one of the templates
RN format

@ilaner
Copy link
Copy Markdown
Contributor

ilaner commented Feb 12, 2023

@johnnywilkes
Please resolve conflicts from demisto/master

@johnnywilkes
Copy link
Copy Markdown
Contributor Author

@ilaner , will fix them. Also, FYI that this is a dependent on full merge of #24575

@johnnywilkes
Copy link
Copy Markdown
Contributor Author

@BigEasyJ , can you re-review please since I have made a few minor changes:

  • 02383b8 : removed marketplace tags
  • a4e8ce1 : change pack readme links
  • a8e55e4 : changed three fields to multiselect and updated stripChars

Copy link
Copy Markdown
Contributor

@BigEasyJ BigEasyJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed updates and approved.

Here is also the ticket in reference to validation errors for changing the field types. Those errors should be ignored.

@johnnywilkes
Copy link
Copy Markdown
Contributor Author

@BigEasyJ , thanks for the review

@ilaner , this has been approved by Xpanse. Team. There are build errors, but talking to @ShacharKidor and @dorschw , they said these could be bypassed with a "force merge." The reason for the field type change was from XSOAR engineering in this ticket: https://jira-hq.paloaltonetworks.local/browse/CRTX-75275
We have done lots of testing and it doesn't seem like a breaking change. Please let me know if you have any questions

Copy link
Copy Markdown
Contributor

@ilaner ilaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@ilaner ilaner added the ForceMerge Forcing the merge of the PR despite the build status label Feb 15, 2023
@ilaner ilaner merged commit 2233b55 into demisto:contrib/johnnywilkes_ASM-EXPANDR-1578 Feb 15, 2023
@content-bot content-bot mentioned this pull request Feb 15, 2023
11 tasks
DeanArbel pushed a commit that referenced this pull request Feb 16, 2023
@johnnywilkes johnnywilkes deleted the ASM-EXPANDR-1578 branch February 21, 2023 20:04
ayman-m pushed a commit to my-soar/content that referenced this pull request Feb 24, 2023
@johnnywilkes johnnywilkes mentioned this pull request Jun 28, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved ForceMerge Forcing the merge of the PR despite the build status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants