Skip to content

Microsoft Sentinel - Enhancement#24528

Merged
mmhw merged 85 commits intomasterfrom
MW_Microsoft_Sentinel_Enhancement_CIAC_1605
Mar 2, 2023
Merged

Microsoft Sentinel - Enhancement#24528
mmhw merged 85 commits intomasterfrom
MW_Microsoft_Sentinel_Enhancement_CIAC_1605

Conversation

@mmhw
Copy link
Copy Markdown
Contributor

@mmhw mmhw commented Feb 9, 2023 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Done

  • Updated API version
  • Added additional incident information to fetch
  • Added the subscription_id and resource_group_name arguments to every command
  • Added mapper
  • Added mirroring (Incoming and Outgoing)
  • Incidents can be closed within Microsoft Sentinel with a provided classification.
  • CRUD alert rules

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@mmhw mmhw self-assigned this Feb 9, 2023
@mmhw mmhw marked this pull request as draft February 9, 2023 15:07
@mmhw mmhw requested a review from bziser February 9, 2023 15:07
bziser
bziser reviewed Feb 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@bziser bziser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Comment thread Packs/AzureSentinel/Integrations/AzureSentinel/AzureSentinel.py Outdated
Comment thread Packs/AzureSentinel/Integrations/AzureSentinel/AzureSentinel.py Outdated
Comment thread Packs/AzureSentinel/Integrations/AzureSentinel/AzureSentinel.py Outdated
Comment thread Packs/AzureSentinel/Integrations/AzureSentinel/AzureSentinel.py Outdated
Comment thread Packs/AzureSentinel/Integrations/AzureSentinel/AzureSentinel.py
bziser
bziser reviewed Feb 12, 2023
View reviewed changes
Comment thread Packs/AzureSentinel/.pack-ignore Outdated
bziser
bziser reviewed Mar 1, 2023
View reviewed changes
Comment thread ...l/Scripts/MicrosoftSentinelConvertEntitiesToTable/MicrosoftSentinelConvertEntitiesToTable.py
Comment thread ...Scripts/MicrosoftSentinelConvertRelationsToTable/MicrosoftSentinelConvertRelationsToTable.py Outdated
Comment thread ...l/Scripts/MicrosoftSentinelConvertCommentsToTable/MicrosoftSentinelConvertCommentsToTable.py Outdated
Comment thread Packs/AzureSentinel/ReleaseNotes/1_5_0.md Outdated
Comment thread Packs/AzureSentinel/ReleaseNotes/1_5_0.md Outdated
bziser
bziser approved these changes Mar 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@bziser bziser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@xsoar-bot
Copy link
Copy Markdown
Contributor

xsoar-bot commented Mar 2, 2023

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/deea32e3-61f5-452b-b57e-dcb78e67aef0/artifacts/0/artifacts/coverage_report/html/index.html

@mmhw mmhw merged commit 797361b into master Mar 2, 2023
@mmhw mmhw deleted the MW_Microsoft_Sentinel_Enhancement_CIAC_1605 branch March 2, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@bziser bziser bziser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ShirleyDenkberg ShirleyDenkberg

@mmhw mmhw

Labels

docs-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmhw @ShirleyDenkberg @xsoar-bot @bziser