Skip to content

separating integration from mm_mail_add_cat#24813

Merged
maimorag merged 17 commits intomasterfrom
mm_mail_add_cat_part_two
Feb 26, 2023
Merged

separating integration from mm_mail_add_cat#24813
maimorag merged 17 commits intomasterfrom
mm_mail_add_cat_part_two

Conversation

@maimorag
Copy link
Copy Markdown
Contributor

@maimorag maimorag commented Feb 22, 2023

Status

  • In Progress

Related Issues

relates: link to the issue

Description

Continue of mm_mail_add_cat- part two:

Reintroduce the Email pack category. packs to include are Email gateways, email packs. e.g: Trustwave, CISCO ESA, Cisco SMA, Proofpoint TAP, Symantec Messaging, Gateway, MimeCast, FireEye EX, EWS O365, EWS v2, Gmail, POP3, Gmail Single User, MS Graph Mail, ArmorBlox, EmailCommunication, Exchange 2016 Complaince, IronScales, MailSender(New), PerceptionPoint.

Minimum version of Cortex XSOAR

  • 6.0.0

Does it break backward compatibility?

  • No

@github-actions
Copy link
Copy Markdown

Your contributed Armorblox pack has been modified on files:

Packs/Armorblox/ReleaseNotes/1_0_9.md
Packs/Armorblox/Integrations/Armorblox/Armorblox.yml
Packs/Armorblox/pack_metadata.json
Please review the changes here

@github-actions
Copy link
Copy Markdown

Your contributed Ironscales pack has been modified on files:

Packs/Ironscales/pack_metadata.json
Packs/Ironscales/ReleaseNotes/1_1_5.md
Packs/Ironscales/Integrations/Ironscales/Ironscales.yml
Please review the changes here

@maimorag maimorag requested review from Shellyber and removed request for a team, GuyLibermanPA, bakatzir and yaakovpraisler February 23, 2023 08:33
Copy link
Copy Markdown
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. some general notes

  1. Update all the relevant release notes with the docker images update
  2. Remove the extra spaces in the release notes files

Comment thread Packs/Armorblox/ReleaseNotes/1_0_10.md
Comment thread Packs/Armorblox/ReleaseNotes/1_0_9.md Outdated
Comment thread Packs/FireEyeEX/ReleaseNotes/2_0_12.md
Comment thread Packs/Gmail/ReleaseNotes/1_3_3.md
Comment thread Packs/GmailSingleUser/ReleaseNotes/1_3_7.md
Comment thread Packs/MailListener_-_POP3/ReleaseNotes/2_0_2.md Outdated
@maimorag maimorag requested a review from Shellyber February 23, 2023 13:27
Copy link
Copy Markdown
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
Let's just verify with @ShirleyDenkberg and @bakatzir regarding the release notes.

Comment thread Packs/Armorblox/ReleaseNotes/1_0_10.md Outdated
#### Integrations

##### Mail Sender (New)
- Updated the pack category to *Email*.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Updated the pack category to *Email*.
Updated the pack category to *Email*.

@ShirleyDenkberg
Copy link
Copy Markdown
Contributor

@Shellyber Review of Release Notes completed.

@xsoar-bot
Copy link
Copy Markdown
Contributor

@maimorag maimorag merged commit 27b4079 into master Feb 26, 2023
@maimorag maimorag deleted the mm_mail_add_cat_part_two branch February 26, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants