Skip to content

CoreIRApiModule - An exception was added in case link is None#24885

Merged
rshunim merged 4 commits intomasterfrom
core_get_script_execution_result_files_bug
Feb 26, 2023
Merged

CoreIRApiModule - An exception was added in case link is None#24885
rshunim merged 4 commits intomasterfrom
core_get_script_execution_result_files_bug

Conversation

@rshunim
Copy link
Copy Markdown
Contributor

@rshunim rshunim commented Feb 26, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

related: link to the issue

Description

If the link is None, the API call will result in a 'connection timed out error', so we raise an exception.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@rshunim rshunim requested a review from dorschw February 26, 2023 15:36
@rshunim rshunim self-assigned this Feb 26, 2023
@rshunim rshunim removed the request for review from dansterenson February 26, 2023 15:38
Comment thread Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py Outdated
@xsoar-bot
Copy link
Copy Markdown
Contributor

@rshunim rshunim merged commit 8c95b93 into master Feb 26, 2023
@rshunim rshunim deleted the core_get_script_execution_result_files_bug branch February 26, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants