Skip to content

ScheduleGenericPolling#24945

Merged
sapirshuker merged 19 commits intomasterfrom
ScheduleGenericPolling_to_py3
Mar 2, 2023
Merged

ScheduleGenericPolling#24945
sapirshuker merged 19 commits intomasterfrom
ScheduleGenericPolling_to_py3

Conversation

@sapirshuker
Copy link
Copy Markdown
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-4174

Description

ScheduleGenericPolling to py3.
Removed encoding to utf-8 (python 3 str support non-engilsh char) according to this PR https://github.com/demisto/content/pull/10150/files#diff-6c4153c0ef71204475f20bae67d3f028ec9cf9e4507679e487c2464122252542
Added test playbook to yml file- Generic Polling Test, Generic Polling Test used GenericPolling as a sub playbook and GenericPolling call to ScheduleGenericPolling script.

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • [] Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

Comment thread Packs/CommonScripts/Scripts/ScheduleGenericPolling/ScheduleGenericPolling.py Outdated
Comment thread Packs/CommonScripts/Scripts/ScheduleGenericPolling/ScheduleGenericPolling.py Outdated
@sapirshuker sapirshuker requested a review from Shellyber March 1, 2023 12:59
Comment thread Packs/CommonScripts/Scripts/ScheduleGenericPolling/ScheduleGenericPolling.py Outdated
Comment thread Packs/CommonScripts/Scripts/ScheduleGenericPolling/ScheduleGenericPolling.py Outdated
@sapirshuker sapirshuker requested a review from Shellyber March 2, 2023 09:59
@sapirshuker sapirshuker merged commit f9a171b into master Mar 2, 2023
@sapirshuker sapirshuker deleted the ScheduleGenericPolling_to_py3 branch March 2, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants