Symantec EDR Integration initial commit#24994
Merged
Conversation
* Initials Symantec EDR branch commit * Intergration with xsoar commands * Generate document * Added all SEDR on-prem commands * Fixed YML file and generate README * restore chagnes * Fixed Incident command * Demos comments fixed * Fixed pylint issue * saved post lint issue with command 25-12 * Added Unit Test cases * Generate Readme or PR review * Fixed README file * Fixed README file * Fixed PR review comments * Fixed PR review comments and mypy lint issue * Removed secret * commit pyupgrade changes * Fixed refurb issue * Fixed Flake8 issue * update docker hub is: 3.10.9.42008 * Restore demisto/master Tests/Marketplace folder with work branch * Added Symantec EDR version in README * Revert all changes under the Tests folder * refactor function parse_event_data_object * added res=response second argument in DemistoException call * added Polling and Fetch Incident changes * fixed fetch Incident duplicate issue * Added Classifier, layout and field types * added all incidents fields in a seperate file * fixed type and layout file type issue * updated pack metadata * change http exception handling with and HTTPError * added sid reuse till not expired * Added raise_for_status access_token func * Fixed all as per review comments * Update SymantecEDR.yml Done. * Update SymantecEDR_description.md Done. * Added all leftover review comments * Changee YML integration ID name * Headers changes and YML fixed * Generate README * fixed lint and YML issue * file command args type issue fixed * Fixed unt test script * Fixed Secrets issue * added .pack-ignore ST108 * added .pack-ignore removed duplicate * added ST109, ST110 .pack-ignore * pack-ignore changes revert * Update SymantecEDR.yml Done. * Update README.md Done. * corrected Error reported from Json files * Fixed Json files validation issues * Identified issue with test data files. Fixed * Corrected version and other changes * Review changes * Address all PR last review comments * Fixed review comments and few test cases * Fixed recent review comments and IF113 Field name issue * resolved MP106 mapper contain incident fields issue and updated latest docker image tag * Fixed [IT104] playbook not found in teh id_set.json file * added test cases * Fixed last review comments * Re-review comments changes * Added client method for all enpoint and fixed argument and return type hints * Added changes after refactoring * removed secret and removed unsupported layout types * update docker image tag and commit review changes * Moved test_module to clinet method * Fixed testing issue as discovered and removed unwanted commented line * Update Packs/SymantecEDR/Integrations/SymantecEDR/SymantecEDR.py * Update Packs/SymantecEDR/Integrations/SymantecEDR/SymantecEDR.py * Update Packs/SymantecEDR/Integrations/SymantecEDR/SymantecEDR.py * fix broken suggestion * refactor 14 repeating commands and updated the Error messages * Update Packs/SymantecEDR/Integrations/SymantecEDR/SymantecEDR.py * removed is_call_diff_readable_output variable * corrected review points * Removed exception from get_incident_uuid method * added lefover test case and system testing fix * remvoed secret * removed secret and code refactoring * refactoring * Code refactoring * comments correction * Update Packs/SymantecEDR/Integrations/SymantecEDR/SymantecEDR.py * Update Packs/SymantecEDR/Integrations/SymantecEDR/SymantecEDR.py * Update Packs/SymantecEDR/Integrations/SymantecEDR/SymantecEDR.py * fixed yml and fields issue * removed test playbook from incident type --------- Co-authored-by: ShirleyDenkberg <[email protected]> Co-authored-by: dorschw <[email protected]>
Contributor
|
Link to the unit tests coverage report: |
dorschw
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@snath-loginsoft
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have