ArcSight ESM v2 - fix as-get-security-events output parsing#7248
Merged
ArcSight ESM v2 - fix as-get-security-events output parsing#7248
Conversation
ronykoz
approved these changes
May 27, 2020
Contributor
|
@Itay4 Looks good, no change. |
yaakovi
approved these changes
May 27, 2020
glicht
reviewed
May 27, 2020
|
|
||
| elif demisto.command() == 'as-get-security-events': | ||
| return_outputs(get_security_events_command()) | ||
| return_outputs(*get_security_events_command()) |
Contributor
There was a problem hiding this comment.
This is inconsistent with the other commands. I think we should change that get_security_events_command calls return_outputs as is done in the other commands.
ronykoz
approved these changes
May 27, 2020
jochman
pushed a commit
that referenced
this pull request
May 27, 2020
* fix as-get-security-events output parsing * bump pack version and add rn * reverted return_outputs call to be in the cmd func
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Description
Fix a breaking change introduced in #6896
Does it break backward compatibility?