fix: handle parsing variable expression in dockerfile#337
Merged
joshspicer merged 4 commits intodevcontainers:mainfrom Jan 3, 2023
Merged
fix: handle parsing variable expression in dockerfile#337joshspicer merged 4 commits intodevcontainers:mainfrom
joshspicer merged 4 commits intodevcontainers:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
chrmarti
requested changes
Dec 28, 2022
Contributor
chrmarti
left a comment
There was a problem hiding this comment.
Thanks for the PR! Left a few comments.
Contributor
Author
|
Known issues: cc: @chrmarti |
chrmarti
approved these changes
Dec 30, 2022
Contributor
chrmarti
left a comment
There was a problem hiding this comment.
LGTM, thanks! (Getting a second reviewer now before we can merge.)
joshspicer
approved these changes
Dec 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #336
Dockerfileas mentioned in Dockerfile references: https://docs.docker.com/engine/reference/builder/#environment-replacement