Add CSS-only nested dropdown submenu primitives#84
Draft
Conversation
✅ Deploy Preview for pui-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Size Change: +274 B (+1.98%) Total Size: 14.1 kB
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
DropdownMenuSub,DropdownMenuSubTrigger, andDropdownMenuSubContentimplemented with the existingcreateSimpleComponentpattern so they incur no runtime overhead.src/components/dropdown-menu/types.ts) and export the new components from the package entrypoint so consumers can use the API.src/components/dropdown-menu/style.cssusing:hoverand:focus-withinto show/hide positioned child panels and supportto="left"alignment for constrained layouts.NestedDropdownDemoindemo/src/routes/home.tsxto exercise two-level nested menus (including a left-flipped second-level submenu) without introducing new command wiring or runtime logic.Testing
pnpm -s buildwhich completed successfully.pnpm -s build && pnpm -s build:demowhich completed successfully and produced a demo build.nested-dropdown.png.pnpm -s exec biome checkon the changed files which reported formatting suggestions (formatter output) and flagged a check failure; the functional builds and demo verification remained successful.Codex Task