Skip to content

fix dropdown-menu commandFor casing and date-picker doc typo #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesism wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix dropdown-menu commandFor casing and date-picker doc typo #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d13cc0b
fix type errors and date-picker doc typo
jamesism Mar 3, 2026
2179276
revert unnecessary changes, fix BaseProps nullability instead
jamesism Mar 3, 2026
930a967
revert BaseProps nullability change
jamesism Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/components/date-picker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {DatePicker} from 'kinu';

| Prop | Type | Default | Description |
| --- | --- | --- | --- |
| value | `string | number | readonly string[] | undefined` | — | Current date value. |
| value | `string \| number \| readonly string[] \| undefined` | — | Current date value. |
| onChange | `(event: Event) => void` | — | Change handler for date input. |
| disabled | `boolean` | — | Disable the input. |
| name | `string` | — | Input name used for form submissions. |
Expand Down
16 changes: 8 additions & 8 deletions src/components/carousel/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import type {
CarouselOwnProps,
CarouselContentOwnProps,
CarouselItemOwnProps,
CarouselPreviousOwnProps,
CarouselNextOwnProps,
CarouselPreviousProps,
CarouselNextProps,
} from './types';
import './style.css';

Expand Down Expand Up @@ -54,10 +54,10 @@ export const CarouselItem = createSimpleComponent<'div', CarouselItemOwnProps>(

export function CarouselPrevious({
children,
commandFor: _commandFor,
command: _command,
command: _c,
commandFor: _cf,
...props
}: CarouselPreviousOwnProps & JSX.HTMLAttributes<HTMLButtonElement>) {
}: CarouselPreviousProps) {
const id = useContext(IdCtx);
return (
<button {...props} k="carousel-previous" command="--prev" commandfor={id ?? undefined}>
Expand All @@ -68,10 +68,10 @@ export function CarouselPrevious({

export function CarouselNext({
children,
commandFor: _commandFor,
command: _command,
command: _c,
commandFor: _cf,
...props
}: CarouselNextOwnProps & JSX.HTMLAttributes<HTMLButtonElement>) {
}: CarouselNextProps) {
const id = useContext(IdCtx);
return (
<button {...props} k="carousel-next" command="--next" commandfor={id ?? undefined}>
Expand Down
2 changes: 1 addition & 1 deletion src/components/dropdown-menu/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export function DropdownMenuContent({
k="dropdown-content"
id={resolvedId}
command={command}
commandFor={commandFor ?? resolvedId}
commandfor={commandFor ?? resolvedId}
{...props}
/>
);
Expand Down
Loading