refactor: improve naming consistency and specify types#4
Merged
devnote-dev merged 2 commits intodevnote-dev:mainfrom Jan 6, 2023
snacks02:consistency
Merged
refactor: improve naming consistency and specify types#4devnote-dev merged 2 commits intodevnote-dev:mainfrom snacks02:consistency
devnote-dev merged 2 commits intodevnote-dev:mainfrom
snacks02:consistency
Conversation
devnote-dev
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome library!
This fixes inconsistent naming (
args=>arguments,cmd=>command,desc=>description,msg=>message,opts=>options) and adds explicit types to some method definitions.