Merged
Conversation
…icon helper Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Review Summary by QodoRelease 0.3.0 - Inline editing, folders, note linking, and auto-updates
WalkthroughsDescription• **Inline note editing**: Expand and edit notes directly in the main list without opening separate windows • **Folder/category system**: Organize notes into folders with dedicated view modes and management UI • **Sorting options**: Sort notes by recent, created date, alphabetical order, color, or size with persistent preferences • **Compact card view**: Toggle between full and compact note card layouts • **Note linking**: Create links between notes using [[note name]] syntax with Ctrl+Click navigation • **Clipboard monitoring**: Track source application and window title when notes are created • **Auto-update system**: Check for updates via GitHub Releases with CPU/CUDA variant detection and in-app download/install • **Startup options**: Start application with Windows and optionally minimize to system tray on launch • **About panel**: Display app information, version, update checker, and links to GitHub and Buy Me a Coffee • **Icon extraction utility**: Extract and cache application icons from executables for clipboard source tracking • **Export functionality**: Export notes as Markdown or plain text with file save and clipboard options • **Drag-and-drop images**: Insert images into notes by dragging from files or browser • **Global hotkey**: Added Ctrl+Alt+V shortcut for paste-as-note feature • **Localization**: Added 60+ new strings in English and French for all new features • **Installer updates**: Version bump to 0.3.0 with application restart support during installation Diagramflowchart LR
A["Clipboard Monitor"] -->|"Track source app"| B["Note Entry"]
B -->|"Organize"| C["Folder System"]
C -->|"Display"| D["Main Window"]
D -->|"Sort by"| E["Recent/Created/Alpha/Color/Size"]
D -->|"Edit inline"| F["Rich Text Editor"]
F -->|"Link notes"| G["Note Linking"]
D -->|"Toggle"| H["Compact View"]
I["Update Service"] -->|"Check GitHub"| J["Auto-Update"]
J -->|"Download & Install"| K["New Version"]
L["Startup Options"] -->|"Configure"| M["App Launch"]
M -->|"Minimize to tray"| N["System Tray"]
O["Icon Helper"] -->|"Extract icons"| P["Source App Display"]
File Changes1. MainWindow.xaml.cs
|
Code Review by Qodo
1. Icon cache compile error
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
📝 WalkthroughWalkthroughThis PR introduces clipboard source tracking, automatic update detection with installer downloads, note linking via Changes
Sequence Diagram(s)sequenceDiagram
participant Clipboard as Windows<br/>Clipboard API
participant Monitor as ClipboardMonitor
participant Win32 as Win32 API
participant App as MainWindow
participant Notes as NotesManager
participant IconHelper as IconHelper
Clipboard->>Monitor: ContentChanged event
Monitor->>Win32: GetForegroundWindow()
Win32-->>Monitor: window handle
Monitor->>Win32: QueryFullProcessImageName()
Win32-->>Monitor: exePath, processID
Monitor->>Win32: GetWindowText()
Win32-->>Monitor: title
Monitor->>Monitor: CleanTitle(title, exePath)
Monitor-->>Monitor: sourceExePath,<br/>sourceTitle stored
App->>Monitor: Read SourceExePath/<br/>SourceTitle
App->>Notes: AddNote() with source
Notes-->>Notes: NoteEntry with<br/>clipboard metadata
App->>IconHelper: LoadIconAsync(exePath)
IconHelper->>IconHelper: Check memory cache
alt Cache miss
IconHelper->>Win32: ExtractIcon,<br/>GetIconInfo, etc.
Win32-->>IconHelper: Icon pixel data
IconHelper->>IconHelper: Encode PNG,<br/>write to disk
end
IconHelper-->>App: Update Image.Source
sequenceDiagram
participant MainWindow as MainWindow
participant UpdateService as UpdateService
participant GitHub as GitHub API
participant Installer as Installer
MainWindow->>UpdateService: CheckForUpdateAsync()
UpdateService->>GitHub: GET /releases/latest
GitHub-->>UpdateService: JSON (tag_name, assets)
UpdateService->>UpdateService: Compare CurrentVersion<br/>vs tag_name
alt Update available
UpdateService-->>UpdateService: Select asset URL<br/>(CUDA or CPU)
UpdateService-->>MainWindow: UpdateInfo record
MainWindow->>MainWindow: Show UpdateBanner
Note over MainWindow: User clicks banner
MainWindow->>UpdateService: DownloadInstallerAsync()
UpdateService->>UpdateService: Stream download<br/>to temp .exe,<br/>report progress
UpdateService-->>MainWindow: installerPath
MainWindow->>UpdateService: LaunchInstallerAndExit(path)
UpdateService->>Installer: Start /SILENT
UpdateService->>UpdateService: Environment.Exit(0)
else No update
UpdateService-->>MainWindow: null
end
sequenceDiagram
participant User as User
participant NoteWindow as NoteWindow Editor
participant Flyout as Note Link Flyout
participant NotesManager as NotesManager
participant App as MainWindow
User->>NoteWindow: Type [[
NoteWindow->>NoteWindow: Detect [[ pattern
NoteWindow->>NotesManager: SearchByTitle(query)
NotesManager-->>NoteWindow: List of notes (up to 10)
NoteWindow->>Flyout: Show suggestions
User->>Flyout: Select note
Flyout->>NoteWindow: Insert note link
NoteWindow->>NoteWindow: Format: visible title +<br/>hidden noteID<br/>(zero-width chars)
NoteWindow->>NoteWindow: Save note
Note over User: Later...
User->>NoteWindow: Ctrl+Click on link
NoteWindow->>NoteWindow: Scan adjacent green text
NoteWindow->>NoteWindow: Extract hidden noteID
NoteWindow->>NoteWindow: Raise NoteLinkClicked(noteId)
NoteWindow-->>App: NoteLinkClicked event
App->>App: OpenNote(noteId)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Comment on lines
+131
to
+142
| using var stream = new InMemoryRandomAccessStream(); | ||
| var encoder = await BitmapEncoder.CreateAsync(BitmapEncoder.PngEncoderId, stream); | ||
| encoder.SetPixelData(BitmapPixelFormat.Bgra8, BitmapAlphaMode.Premultiplied, | ||
| (uint)w, (uint)h, 96, 96, bgra); | ||
| await encoder.FlushAsync(); | ||
|
|
||
| stream.Seek(0); | ||
| var bytes = new byte[stream.Size]; | ||
| var reader = new DataReader(stream); | ||
| await reader.LoadAsync((uint)bytes.Length); | ||
| reader.ReadBytes(bytes); | ||
| return bytes; |
There was a problem hiding this comment.
1. Icon cache compile error 🐞 Bug ✓ Correctness
IconHelper.EncodePngAsync allocates new byte[stream.Size], but stream.Size is not an int, so this code does not compile and blocks the build.
Agent Prompt
### Issue description
`EncodePngAsync` uses `new byte[stream.Size]`, which fails to compile because the array length must be an `int`.
### Issue Context
This prevents the entire project from building.
### Fix Focus Areas
- IconHelper.cs[127-145]
### Suggested fix
- Convert `stream.Size` to an `int` safely (e.g., `var len = checked((int)stream.Size); var bytes = new byte[len];`).
- Prefer `using var reader = new DataReader(stream.GetInputStreamAt(0));` and dispose/detach reader if needed.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+97
to
118
| <!-- Update banner --> | ||
| <Button x:Name="UpdateBanner" Grid.Row="3" Visibility="Collapsed" | ||
| HorizontalAlignment="Stretch" HorizontalContentAlignment="Center" | ||
| Background="{ThemeResource AccentFillColorDefaultBrush}" | ||
| Foreground="{ThemeResource TextOnAccentFillColorPrimaryBrush}" | ||
| BorderThickness="0" CornerRadius="6" Margin="12,0,12,8" | ||
| Padding="8,6" MinHeight="0" FontSize="12" | ||
| Click="UpdateBanner_Click"> | ||
| <StackPanel Orientation="Horizontal" Spacing="6"> | ||
| <FontIcon Glyph="" FontSize="12" | ||
| Foreground="{ThemeResource TextOnAccentFillColorPrimaryBrush}"/> | ||
| <TextBlock x:Name="UpdateBannerText" Text="" VerticalAlignment="Center" | ||
| Foreground="{ThemeResource TextOnAccentFillColorPrimaryBrush}"/> | ||
| </StackPanel> | ||
| </Button> | ||
|
|
||
| <!-- Row 3: Notes list --> | ||
| <ScrollViewer x:Name="NotesScroll" Grid.Row="3" Padding="12,0,12,12" | ||
| VerticalScrollBarVisibility="Auto"> | ||
| <StackPanel x:Name="NotesList" Spacing="8"/> | ||
| VerticalScrollBarVisibility="Auto" | ||
| Background="Transparent" PointerPressed="NotesScroll_PointerPressed"> | ||
| <StackPanel x:Name="NotesList" Spacing="8" Background="Transparent"/> | ||
| </ScrollViewer> |
There was a problem hiding this comment.
2. Update banner z-order overlap 🐞 Bug ✓ Correctness
UpdateBanner and NotesScroll are both placed in Grid.Row="3", and NotesScroll is declared after the banner, so it will render on top and intercept input, making the banner effectively hidden/un-clickable when shown.
Agent Prompt
### Issue description
`UpdateBanner` shares the same `Grid.Row` as `NotesScroll` and is declared before it, so it will be covered by the ScrollViewer.
### Issue Context
This likely prevents users from seeing/clicking the update prompt.
### Fix Focus Areas
- MainWindow.xaml[97-118]
### Suggested fix
Choose one:
1) Add a dedicated grid row for the banner and move `NotesScroll` to the next row.
2) Keep same row but declare `UpdateBanner` after `NotesScroll` and/or set `Canvas.ZIndex` (or equivalent) so the banner is on top, and add top margin/padding to `NotesScroll` to avoid content being obscured.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+80
to
+127
| /// <summary>Downloads the installer to a temp file and returns the path.</summary> | ||
| public static async Task<string?> DownloadInstallerAsync(string downloadUrl, IProgress<double>? progress = null) | ||
| { | ||
| try | ||
| { | ||
| using var response = await Http.GetAsync(downloadUrl, HttpCompletionOption.ResponseHeadersRead); | ||
| if (!response.IsSuccessStatusCode) | ||
| return null; | ||
|
|
||
| var totalBytes = response.Content.Headers.ContentLength ?? -1; | ||
| var tempPath = Path.Combine(Path.GetTempPath(), $"NoteUI-Setup-{Guid.NewGuid():N}.exe"); | ||
|
|
||
| await using var contentStream = await response.Content.ReadAsStreamAsync(); | ||
| await using var fileStream = new FileStream(tempPath, FileMode.Create, FileAccess.Write, FileShare.None, 8192, true); | ||
|
|
||
| var buffer = new byte[81920]; | ||
| long totalRead = 0; | ||
| int bytesRead; | ||
|
|
||
| while ((bytesRead = await contentStream.ReadAsync(buffer)) > 0) | ||
| { | ||
| await fileStream.WriteAsync(buffer.AsMemory(0, bytesRead)); | ||
| totalRead += bytesRead; | ||
| if (totalBytes > 0) | ||
| progress?.Report((double)totalRead / totalBytes); | ||
| } | ||
|
|
||
| progress?.Report(1.0); | ||
| return tempPath; | ||
| } | ||
| catch | ||
| { | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| /// <summary>Launches the downloaded installer with /SILENT and exits the app.</summary> | ||
| public static void LaunchInstallerAndExit(string installerPath) | ||
| { | ||
| Process.Start(new ProcessStartInfo | ||
| { | ||
| FileName = installerPath, | ||
| Arguments = "/SILENT", | ||
| UseShellExecute = true | ||
| }); | ||
|
|
||
| Environment.Exit(0); | ||
| } |
There was a problem hiding this comment.
3. Updater runs unverified exe 🐞 Bug ⛨ Security
The auto-update flow downloads an installer EXE and executes it without verifying Authenticode signature or a known checksum, so a compromised download could lead to arbitrary code execution.
Agent Prompt
### Issue description
Downloaded update installers are executed without integrity/authenticity verification.
### Issue Context
The download URL comes from GitHub API, but defense-in-depth still requires verifying the downloaded binary before executing.
### Fix Focus Areas
- UpdateService.cs[80-127]
### Suggested fix
Implement at least one verification layer before `Process.Start`:
- Verify Authenticode signature matches an expected publisher certificate.
- And/or ship an expected SHA-256 checksum (or fetch checksums from release assets) and validate the downloaded file.
- Refuse to execute and surface an error state if verification fails.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Summary by CodeRabbit
Release Notes
New Features
[[noteTitle]]syntax.Bug Fixes