Conversation
remove travis ci and local conda recipe
I would add a pyproject.toml. it only needs to have the |
|
cpplint would be good but let's get everything working first. |
|
remove travis and conda recipe": correct |
|
is there a reason why the tests are not funning on the PR? Do tests pass? |
|
@sbillinge Thanks for the comments. This cpp library doesn't use setuptool, and I think adding a pyproject.toml is fine. We never got the original tests to work, and I believe we discussed this before and decided to rewrite all tests using modernized cpp testing suits. All the tests on this for now depend on |
We should discuss on how we setup codespell here, as in regular skpkg packages we refer to
ignore_wordsandignore_linesin pyproject.toml, which doesn't exist here. I'm able to use theignore_wordfile directly into pre-commit.yaml by making it a shell command (which force the comment symbol from;;to#), but I'm not sure how to addignore_lines.We might also want to add an extra cpplint check after some maintenance is done on the code. I already added it in
.pre-commit-config.yamlbut commented out for now.@sbillinge please check, thanks!