-
Notifications
You must be signed in to change notification settings - Fork 238
change return type of find_batched() utility function #1310
Copy link
Copy link
Closed
Labels
DocArray v2This issue is part of the rewrite; not to be merged into mainThis issue is part of the rewrite; not to be merged into maingood-first-issueSuitable as your first contribution to DocArray!Suitable as your first contribution to DocArray!
Description
Currently, find_batched() has the following signature:
def find_batched(
...
) -> List[FindResult]:In order to align with DocumentIndex, it should be switched to:
def find_batched(
...
) -> FindResultBatched:TODOs:
- move the definition of
FindResultBatchedfromindex/abstract.pytoutils/find.py - change the signature as described above
- fix the imports on all Document Index classes
- Probably
FindResultBatchedneeds a tweak as well:scores: np.ndarrayprobably needs to be changed to allow a union of ndarray, torch.Tensor and tf.Tensor
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
DocArray v2This issue is part of the rewrite; not to be merged into mainThis issue is part of the rewrite; not to be merged into maingood-first-issueSuitable as your first contribution to DocArray!Suitable as your first contribution to DocArray!
Type
Projects
Status
Done