refactor: change return type of find batched#1339
Merged
JohannesMessner merged 8 commits intodocarray:feat-rewrite-v2from Apr 14, 2023
Merged
refactor: change return type of find batched#1339JohannesMessner merged 8 commits intodocarray:feat-rewrite-v2from
JohannesMessner merged 8 commits intodocarray:feat-rewrite-v2from
Conversation
JohannesMessner
requested changes
Apr 5, 2023
348415a to
8122e92
Compare
43c6dd7 to
8608a68
Compare
samsja
approved these changes
Apr 13, 2023
JohannesMessner
requested changes
Apr 13, 2023
Member
JohannesMessner
left a comment
There was a problem hiding this comment.
I would like to wait with merging this PR until weaviate and qdrant are merged.
The reason is that they both had to do a teeny tiny change to FindRestulBatched (the same change for both of them) that will conflict with this.
So since these are big PR coming from external partners, I would rather not cause them additional troubles, so I would merge their PRs first, then merge this one and resolve the conflicts
0d12ef4 to
16f23da
Compare
JohannesMessner
requested changes
Apr 14, 2023
3dcbf60 to
bae39aa
Compare
JohannesMessner
requested changes
Apr 14, 2023
Signed-off-by: Nikos Pitsillos <[email protected]>
Signed-off-by: Nikos Pitsillos <[email protected]>
Signed-off-by: Nikos Pitsillos <[email protected]>
Signed-off-by: Nikos Pitsillos <[email protected]>
Signed-off-by: Nikos Pitsillos <[email protected]>
Signed-off-by: Nikos Pitsillos <[email protected]>
Signed-off-by: Nikos Pitsillos <[email protected]>
79cfdc6 to
f889c0a
Compare
Signed-off-by: Nikos Pitsillos <[email protected]>
JohannesMessner
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
Closes change return type of
find_batched()utility function #1310check and update documentation, if required. See guide