Merged
Conversation
Member
|
So if I understand correctly, this basically caches the parametrized classes so that they will not be recreated when it is not necessaray, right? Are there any scenarios where we could end up with two class "instances" with two different caches, such that the original problem could still occur? Maybe through multi-threading/processing? Not sure myself... |
Signed-off-by: Jackmin801 <[email protected]>
Signed-off-by: Jackmin801 <[email protected]>
Signed-off-by: Jackmin801 <[email protected]>
Signed-off-by: Jackmin801 <[email protected]>
3e7ea81 to
01e3232
Compare
Contributor
Author
|
I dont think worker processes can return a class that was defined in the worker process anyways. So even if different instances existed, it would be illegal for them to interact. |
samsja
reviewed
Jan 25, 2023
samsja
requested changes
Jan 25, 2023
Member
samsja
left a comment
There was a problem hiding this comment.
oups I forgot that I ask for a change
9c39fe4 to
01e3232
Compare
|
📝 Docs are deployed on https://ft-fix-1041-typed-da-classing--jina-docs.netlify.app 🎉 |
samsja
approved these changes
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals: