Skip to content

feat: display columns information for stacked array#1052

Merged
anna-charlotte merged 8 commits intofeat-rewrite-v2from
feat-display-stacked-array
Jan 26, 2023
Merged

feat: display columns information for stacked array#1052
anna-charlotte merged 8 commits intofeat-rewrite-v2from
feat-display-stacked-array

Conversation

@anna-charlotte
Copy link
Copy Markdown
Contributor

@anna-charlotte anna-charlotte commented Jan 25, 2023

Signed-off-by: anna-charlotte [email protected]

Goals:

For a DocumentArrayStacked instance add some information of the stacked columns to its summary, such as the following:

image

Handle the following cases:

  • stacked array is None
  • stacked array is NdArray
  • stacked array is TorchTensor: additionally show device
  • check and update documentation, if required. See guide

anna-charlotte added 7 commits January 26, 2023 13:40
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
@anna-charlotte anna-charlotte force-pushed the feat-display-stacked-array branch from c3d7a59 to e5c5dcf Compare January 26, 2023 12:41
@anna-charlotte anna-charlotte marked this pull request as ready for review January 26, 2023 13:25
@github-actions
Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-display-stacked-array--jina-docs.netlify.app 🎉

Copy link
Copy Markdown
Member

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one minor comment

@anna-charlotte anna-charlotte merged commit 922f182 into feat-rewrite-v2 Jan 26, 2023
@anna-charlotte anna-charlotte deleted the feat-display-stacked-array branch January 26, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants