Merged
Conversation
8f4302d to
5c3938f
Compare
samsja
requested changes
Jan 31, 2023
Member
samsja
left a comment
There was a problem hiding this comment.
can we add it to the docstring ?
Signed-off-by: Joan Fontanals Martinez <[email protected]>
5c3938f to
365e718
Compare
Member
Author
Check now |
|
📝 Docs are deployed on https://ft-feat-init-Text-directly--jina-docs.netlify.app 🎉 |
Member
Author
|
partially fix : #1056 |
JohannesMessner
approved these changes
Feb 1, 2023
Member
JohannesMessner
left a comment
There was a problem hiding this comment.
I wonder if we can automate this for all of our pre-built docs. They could define something like __docarray_main_field__ that just points to the correct field and then in the BaseDocument it does exactly what you are doing here
samsja
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
Solves #1056
Allows to have a less-verbose
Textinitalization:works