Skip to content

feat: elasticsearch(v8) document index #1251

Merged
AnneYang720 merged 22 commits intofeat-rewrite-v2from
feat-elastic-v8
Apr 13, 2023
Merged

feat: elasticsearch(v8) document index #1251
AnneYang720 merged 22 commits intofeat-rewrite-v2from
feat-elastic-v8

Conversation

@AnneYang720
Copy link
Copy Markdown
Contributor

@AnneYang720 AnneYang720 commented Mar 17, 2023 •
edited
Loading

Goals:

This PR will implement ElasticSearch Document Store based on elastic v8 #1250. The PR for v7 is #1196 .
Related issue: #1209 #1181 .

There will be another ticket&PR for elastic v8.

  • code
  • tests
  • ci
  • resolve conflicts

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 17, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@AnneYang720 AnneYang720 marked this pull request as draft March 23, 2023 06:06
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@AnneYang720
fix: update
6ba2f32 
Signed-off-by: AnneY <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@AnneYang720
fix: update poetry
c0a3c5d 
Signed-off-by: AnneY <[email protected]>
@AnneYang720 AnneYang720 marked this pull request as ready for review March 31, 2023 06:52
@github-actions github-actions bot added size/xl and removed size/l labels Mar 31, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

JohannesMessner
JohannesMessner reviewed Apr 11, 2023
View reviewed changes
JohannesMessner
JohannesMessner requested changes Apr 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@JohannesMessner JohannesMessner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small stuff, looking good!

JohannesMessner
JohannesMessner requested changes Apr 11, 2023
View reviewed changes
@AnneYang720
fix: minor fix
5f17684 
Signed-off-by: AnneY <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 11, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 11, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@AnneYang720
feat: add ip_range
0cc9e64 
Signed-off-by: AnneY <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 13, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 13, 2023

📝 Docs are deployed on https://ft-feat-elastic-v8--jina-docs.netlify.app 🎉

@AnneYang720 AnneYang720 merged commit bd41ce6 into feat-rewrite-v2 Apr 13, 2023
@AnneYang720 AnneYang720 deleted the feat-elastic-v8 branch April 13, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsja samsja samsja left review comments

@JohannesMessner JohannesMessner JohannesMessner approved these changes

Assignees

No one assigned

Labels

area/cicd area/core area/housekeeping area/setup area/testing size/xl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AnneYang720 @JohannesMessner @samsja