Skip to content

fix: bytes type in TextDoc and VideoDoc #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsja merged 2 commits into from
Mar 22, 2023
Merged

fix: bytes type in TextDoc and VideoDoc #1270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa4a150
fix: bytes type is None in predefined documents
Mar 22, 2023
0b55881
fix: remove defaults to none
Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions docarray/documents/text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ class TextDoc(BaseDocument):
from docarray.typing import AnyEmbedding
from typing import Optional


# extend it
class MyText(Text):
second_embedding: Optional[AnyEmbedding]
Expand All @@ -62,6 +63,7 @@ class MyText(Text):
from docarray import BaseDocument
from docarray.documents import ImageDoc, TextDoc


# compose it
class MultiModalDoc(BaseDocument):
image_doc: Image
Expand Down Expand Up @@ -96,10 +98,10 @@ class MultiModalDoc(BaseDocument):
doc == doc2 # False, their ids are not equivalent
"""

text: Optional[str] = None
url: Optional[TextUrl] = None
embedding: Optional[AnyEmbedding] = None
bytes: Optional[bytes] = None
text: Optional[str]
url: Optional[TextUrl]
embedding: Optional[AnyEmbedding]
bytes: Optional[bytes]

def __init__(self, text: Optional[str] = None, **kwargs):
if 'text' not in kwargs:
Expand Down
2 changes: 1 addition & 1 deletion docarray/documents/video.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class MultiModalDoc(BaseDocument):
tensor: Optional[VideoTensor]
key_frame_indices: Optional[AnyTensor]
embedding: Optional[AnyEmbedding]
bytes: Optional[bytes] = None
bytes: Optional[bytes]

@classmethod
def validate(
Expand Down