Skip to content

docs: multi modalities#1317

Merged
samsja merged 86 commits intofeat-rewrite-v2from
docs-multi-modalities
Apr 12, 2023
Merged

docs: multi modalities#1317
samsja merged 86 commits intofeat-rewrite-v2from
docs-multi-modalities

Conversation

@anna-charlotte
Copy link
Copy Markdown
Contributor

@anna-charlotte anna-charlotte commented Mar 30, 2023 •
edited
Loading

Goals:
Add a section for data types, like image, audio and more.
Similar to v1 data types section, we want to have:

  • one section for each modailty

For each section:

  • Show each docarray.typing related type. Tensor, Url, Bytes
  • Show the display function
  • Show the predefined documents related to this modalities

@anna-charlotte anna-charlotte linked an issue Mar 30, 2023 that may be closed by this pull request
DOCS: multi modalities #1313
Closed
docs: add multi modalities section
e145948 
Signed-off-by: anna-charlotte <[email protected]>
@anna-charlotte anna-charlotte force-pushed the docs-multi-modalities branch from bde257a to e145948 Compare March 30, 2023 11:36
fix: data types section add :
75202ba 
Signed-off-by: anna-charlotte <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

7 similar comments
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@anna-charlotte anna-charlotte force-pushed the docs-multi-modalities branch from d333e1e to 9d9bade Compare April 3, 2023 08:07
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

2 similar comments
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@anna-charlotte anna-charlotte force-pushed the docs-multi-modalities branch from 3b3deee to c851b71 Compare April 3, 2023 12:21
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

fix: apply suggestions
0ed8f0f 
Signed-off-by: anna-charlotte <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 11, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 11, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 11, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

fix: docs tests
fae8221 
Signed-off-by: anna-charlotte <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 11, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

anna-charlotte added 2 commits April 12, 2023 09:10
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

anna-charlotte added 4 commits April 12, 2023 10:30
fix: image section
9e6ef37 
Signed-off-by: anna-charlotte <[email protected]>
docs: fix tests
675b0a3 
Signed-off-by: anna-charlotte <[email protected]>
test: adjust test_docs
ecc753b 
Signed-off-by: anna-charlotte <[email protected]>
Merge remote-tracking branch 'origin/feat-rewrite-v2' into docs-multi…
65162ce 
…-modalities

Signed-off-by: anna-charlotte <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

fix: adjust paths to github files
cc7de45 
Signed-off-by: anna-charlotte <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

fix: doc string test for documents
5b4e575 
Signed-off-by: anna-charlotte <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@anna-charlotte anna-charlotte marked this pull request as ready for review April 12, 2023 11:53
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@anna-charlotte anna-charlotte requested a review from alexcg1 April 12, 2023 12:02
fix: run grammarly on .md files
a3c6332 
Signed-off-by: anna-charlotte <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2023

📝 Docs are deployed on https://ft-docs-multi-modalities--jina-docs.netlify.app 🎉

@samsja samsja merged commit b8f178e into feat-rewrite-v2 Apr 12, 2023
@samsja samsja deleted the docs-multi-modalities branch April 12, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohannesMessner JohannesMessner JohannesMessner approved these changes

@samsja samsja samsja approved these changes

@alexcg1 alexcg1 Awaiting requested review from alexcg1

Assignees

No one assigned

Labels

area/core area/docs area/setup area/testing area/typing component/array size/xl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DOCS: multi modalities

3 participants

@anna-charlotte @JohannesMessner @samsja