fix: return audio, image specific types in .load() and .load_bytes()#1328
Merged
anna-charlotte merged 6 commits intofeat-rewrite-v2from Apr 3, 2023
Merged
fix: return audio, image specific types in .load() and .load_bytes()#1328anna-charlotte merged 6 commits intofeat-rewrite-v2from
.load() and .load_bytes()#1328anna-charlotte merged 6 commits intofeat-rewrite-v2from
Conversation
19c49cb to
b50a93a
Compare
added 5 commits
April 3, 2023 10:04
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
d59500c to
64f895c
Compare
Signed-off-by: anna-charlotte <[email protected]>
|
📝 Docs are deployed on https://ft-fix-url-load-return-type--jina-docs.netlify.app 🎉 |
samsja
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
Change return type of
.load()from np.ndarray toAudioNdArray/ImageNdArrayand.load_bytes()from bytes toAudioBytes/ImageBytes.Currently we return np.ndarrays, in the example below it will be cast to AudioNdArray, but PyCharm does not realize this, and therefore does not offer autocompletion, and e.g. complains in line 13 with
Unresolved attribute reference 'save' for class 'ndarray'.