fix: in .to_bytes() return type specific bytes#1341
Merged
anna-charlotte merged 5 commits intofeat-rewrite-v2from Apr 6, 2023
Merged
fix: in .to_bytes() return type specific bytes#1341anna-charlotte merged 5 commits intofeat-rewrite-v2from
.to_bytes() return type specific bytes#1341anna-charlotte merged 5 commits intofeat-rewrite-v2from
Conversation
added 3 commits
April 5, 2023 19:14
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
|
📝 Docs are deployed on https://ft-fix-to-bytes-return-videobytes--jina-docs.netlify.app 🎉 |
anna-charlotte
commented
Apr 6, 2023
| Convert audio tensor to bytes. | ||
| Convert audio tensor to AudioBytes. | ||
| """ | ||
| from docarray.typing.bytes.audio_bytes import AudioBytes |
Contributor
Author
There was a problem hiding this comment.
not sure if this is a problem, but had to put the import inside the method due to a circular import issue.
samsja
approved these changes
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
Currently
.to_bytes()method returns bytes. Let's returnVideoBytes,ImageBytes,AudioBytesinstead. Similar to howload_bytes()returns those type specific bytes, too.