docs: add storing with file#1348
Merged
anna-charlotte merged 21 commits intofeat-rewrite-v2from Apr 14, 2023
Merged
Conversation
Contributor
|
hey @nan-wang do you mind if I take over this PR? |
e2427c4 to
dfae816
Compare
9254472 to
a75f7a1
Compare
samsja
reviewed
Apr 14, 2023
samsja
requested changes
Apr 14, 2023
Member
samsja
left a comment
There was a problem hiding this comment.
Looks really good ! .
on comment, can we put the three docs about push pull into a common folder ? So that we have distinction between DocStore and DocIndex 
Signed-off-by: nan-wang <[email protected]> Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: nan-wang <[email protected]> Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: nan-wang <[email protected]> Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
* docs(menu): consistency, wording fixes Signed-off-by: Alex C-G <[email protected]> * docs(intro): remove redundancy in title Signed-off-by: Alex C-G <[email protected]> --------- Signed-off-by: Alex C-G <[email protected]> Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: AnneY <[email protected]> Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
This reverts commit a52fed5. Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
* docs: add serialization for json Signed-off-by: nan-wang <[email protected]> * docs: add serialization for binary and protobuf Signed-off-by: nan-wang <[email protected]> * docs: add serialization for base64 and bytes Signed-off-by: nan-wang <[email protected]> * docs: add serialization for csv Signed-off-by: nan-wang <[email protected]> * docs: add serialization for dataframe Signed-off-by: nan-wang <[email protected]> * fix: add doctring to documentaion basedoc Signed-off-by: samsja <[email protected]> * fix: fix mypy Signed-off-by: samsja <[email protected]> * fix: add docstring doc list Signed-off-by: samsja <[email protected]> * fix: dic doc array docstring Signed-off-by: samsja <[email protected]> * fix: fix page for doc list serilizaiton Signed-off-by: samsja <[email protected]> * fix: fix docstring Signed-off-by: samsja <[email protected]> * feat: add docvec Signed-off-by: samsja <[email protected]> * docs: add send doc section Signed-off-by: samsja <[email protected]> * docs: fix docstring Signed-off-by: samsja <[email protected]> * refactor: better tree structure for sending Signed-off-by: samsja <[email protected]> * fix: fix tests Signed-off-by: samsja <[email protected]> * fix: fix python code snippet ods Signed-off-by: samsja <[email protected]> * fix: fix remove breakpoint Signed-off-by: samsja <[email protected]> * feat: add intro Signed-off-by: samsja <[email protected]> * feat: add ref Signed-off-by: samsja <[email protected]> * feat: move fastapi part Signed-off-by: samsja <[email protected]> * fix: fix fastAPI Signed-off-by: samsja <[email protected]> * fix: remove uselss mixin Signed-off-by: samsja <[email protected]> * faet: add jina section Signed-off-by: samsja <[email protected]> * fix: compress -> compression Signed-off-by: samsja <[email protected]> * feat: apply suggestion Co-authored-by: Alex Cureton-Griffiths <[email protected]> Co-authored-by: Charlotte Gerhaher <[email protected]> Signed-off-by: samsja <[email protected]> * fix: apply alex suggestion Signed-off-by: samsja <[email protected]> * wip Signed-off-by: samsja <[email protected]> * fix: fix all docstring Signed-off-by: samsja <[email protected]> * fix: fix update docstring Signed-off-by: samsja <[email protected]> * fix: fix ruff Signed-off-by: samsja <[email protected]> * fix: fix smth Signed-off-by: samsja <[email protected]> * feat: apply charllote suggestion Co-authored-by: Charlotte Gerhaher <[email protected]> Signed-off-by: samsja <[email protected]> --------- Signed-off-by: nan-wang <[email protected]> Signed-off-by: samsja <[email protected]> Signed-off-by: samsja <[email protected]> Co-authored-by: samsja <[email protected]> Co-authored-by: samsja <[email protected]> Co-authored-by: Alex Cureton-Griffiths <[email protected]> Co-authored-by: Charlotte Gerhaher <[email protected]>
Co-authored-by: samsja <[email protected]> Signed-off-by: Charlotte Gerhaher <[email protected]> Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
* docs: add links and clean up Signed-off-by: anna-charlotte <[email protected]> * fix: Text to TextDoc Signed-off-by: anna-charlotte <[email protected]> * fix: 3d urls Signed-off-by: anna-charlotte <[email protected]> * fix: pc url Signed-off-by: anna-charlotte <[email protected]> * fix: comment out display pc Signed-off-by: anna-charlotte <[email protected]> --------- Signed-off-by: anna-charlotte <[email protected]>
7097f98 to
597cd3a
Compare
…-0409 Signed-off-by: anna-charlotte <[email protected]>
|
📝 Docs are deployed on https://ft-docs-store-0409--jina-docs.netlify.app 🎉 |
samsja
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals: