Skip to content

fix mypy #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsja merged 3 commits into from
Apr 14, 2023
Merged

fix mypy #1371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13b63ef
fix: fix mypy 1
samsja Apr 14, 2023
18de7f4
fix: fix mypy 2
samsja Apr 14, 2023
738191c
fix: fix import
samsja Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docarray/index/abstract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,8 @@ def text_search_batched(
docs = [self._dict_list_to_docarray(docs) for docs in da_list]
return FindResultBatched(documents=docs, scores=scores)

return FindResultBatched(documents=da_list, scores=scores)
da_list_ = cast(List[DocList], da_list)
return FindResultBatched(documents=da_list_, scores=scores)

##########################################################
# Helper methods #
Expand Down
5 changes: 4 additions & 1 deletion docarray/index/backends/hnswlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
_raise_not_supported,
)
from docarray.proto import DocProto
from docarray.typing import NdArray
from docarray.typing.tensor.abstract_tensor import AbstractTensor
from docarray.utils._internal.misc import import_library, is_np_int
from docarray.utils.filter import filter_docs
Expand Down Expand Up @@ -262,7 +263,9 @@ def _find(
docs, scores = self._find_batched(
queries=query_batched, limit=limit, search_field=search_field
)
return _FindResult(documents=docs[0], scores=scores[0])
return _FindResult(
documents=docs[0], scores=NdArray._docarray_from_native(scores[0])
)

def _filter(
self,
Expand Down