feat: add compression and protocol in file name#138
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #138 +/- ##
==========================================
- Coverage 83.89% 83.87% -0.02%
==========================================
Files 106 108 +2
Lines 4551 4651 +100
==========================================
+ Hits 3818 3901 +83
- Misses 733 750 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JoanFM
reviewed
Feb 23, 2022
numb3r3
suggested changes
Feb 24, 2022
|
📝 Docs are deployed on https://ft-feat-add-serialization-info--jina-docs.netlify.app 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now there is the issue that if a
DocumentArrayis stored as binary users need to remember compression and protocol to load it back.This PR adds this information as extensions in the file.
Example
will save
Thefore, later on users don't need to recall which
protocolandcompresswere used.Since the information is in the string this PR parses it so that users don't need to pass this info as keyword arguments to
load_binary. They can simply do:This PR solves #128