Skip to content

fix: fix push pull#1384

Merged
samsja merged 3 commits intomainfrom
fix-push-pull
Apr 17, 2023
Merged

fix: fix push pull#1384
samsja merged 3 commits intomainfrom
fix-push-pull

Conversation

@samsja
Copy link
Copy Markdown
Member

@samsja samsja commented Apr 17, 2023

Context

this pr fix the push pull to JAC and make to_bynary_stream private

Signed-off-by: samsja <[email protected]>
Copy link
Copy Markdown
Contributor

@nomagick nomagick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@samsja samsja marked this pull request as ready for review April 17, 2023 08:59
samsja added 2 commits April 17, 2023 11:48
Signed-off-by: samsja <[email protected]>
@github-actions
Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-push-pull--jina-docs.netlify.app 🎉

@samsja samsja requested a review from JohannesMessner April 17, 2023 10:07
@samsja samsja merged commit c45e349 into main Apr 17, 2023
@samsja samsja deleted the fix-push-pull branch April 17, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants