docs: fix doc store code snippet in README.md#1389
Merged
anna-charlotte merged 4 commits intomainfrom Apr 17, 2023
Merged
Conversation
Signed-off-by: anna-charlotte <[email protected]>
samsja
reviewed
Apr 17, 2023
README.md
Outdated
|
|
||
|
|
||
| # first create a personal access token here: https://cloud.jina.ai/settings/tokens | ||
| os.environ['JINA_AUTH_TOKEN'] = 'YOUR_PAT' |
Member
There was a problem hiding this comment.
will this work even if the auth token is YOU_PAT ?
Contributor
Author
There was a problem hiding this comment.
ah no, you're right, won't work.
Contributor
Author
There was a problem hiding this comment.
will change to the on-disk example
Signed-off-by: anna-charlotte <[email protected]>
samsja
approved these changes
Apr 17, 2023
alexcg1
suggested changes
Apr 17, 2023
Co-authored-by: Alex Cureton-Griffiths <[email protected]> Signed-off-by: Charlotte Gerhaher <[email protected]>
|
📝 Docs are deployed on https://ft-docs-readme-doc-store--jina-docs.netlify.app 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix doc store code example in the README.md (using jina ai cloud example instead of s3 bucket)