fix: passes max_element when load index in hnswlib#1426
Merged
Conversation
Signed-off-by: AnneY <[email protected]>
JoanFM
requested changes
Apr 20, 2023
Member
JoanFM
left a comment
There was a problem hiding this comment.
Please use this PR to add the tests discussed in discord
JoanFM
requested changes
Apr 20, 2023
Signed-off-by: AnneY <[email protected]>
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Signed-off-by: AnneY <[email protected]>
a2d5f6c to
6bb36d9
Compare
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
📝 Docs are deployed on https://ft-fix-hnsw-load--jina-docs.netlify.app 🎉 |
JoanFM
approved these changes
Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the additional fix for PR #1424 .
We need to pass
max_elementsin methodload_index(), otherwise it's reset to 0.