Skip to content

feat: add config to load more field that the schema#1437

Merged
samsja merged 8 commits intomainfrom
fix-proto-anydoc
Apr 26, 2023
Merged

feat: add config to load more field that the schema#1437
samsja merged 8 commits intomainfrom
fix-proto-anydoc

Conversation

@samsja
Copy link
Copy Markdown
Member

@samsja samsja commented Apr 24, 2023

Context

the goal of this pr is to allow AnyDoc to load any protobuf file without knowing the class beforehand

code example :

from docarray.base_doc.any_doc import AnyDoc

doc = AnyDoc(hello='world')

print(f"doc= \n {doc}")
pt = doc.to_protobuf()
print(f"pt= \n {pt}")
doc2 = AnyDoc.from_protobuf(pt)
print(f"doc2= \n {doc2}")
assert doc2.dict()['hello'] == 'world'

@samsja
feat: add test
49f20ca 
Signed-off-by: samsja <[email protected]>
@github-actions github-actions bot added size/m and removed size/s labels Apr 26, 2023
@samsja samsja marked this pull request as ready for review April 26, 2023 07:59
@samsja
fix: fix test
1b35ae3 
Signed-off-by: samsja <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 26, 2023

📝 Docs are deployed on https://ft-fix-proto-anydoc--jina-docs.netlify.app 🎉

@samsja samsja merged commit 83e7384 into main Apr 26, 2023
@samsja samsja deleted the fix-proto-anydoc branch April 26, 2023 08:20
@samsja samsja mentioned this pull request Apr 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoanFM JoanFM JoanFM approved these changes

@JohannesMessner JohannesMessner Awaiting requested review from JohannesMessner

Assignees

No one assigned

Labels

area/core area/testing size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsja @JoanFM