Conversation
Signed-off-by: anna-charlotte <[email protected]>
docarray/index/backends/in_memory.py
Outdated
|
|
||
| def execute_query(self, query: List[str], *args, **kwargs) -> Any: | ||
| """ | ||
| Execute a query on the HnswDocumentIndex. |
There was a problem hiding this comment.
| Execute a query on the HnswDocumentIndex. | |
| Execute a query on the InMemoryIndex. |
There was a problem hiding this comment.
WHat is this Query? what QL will it follow?
There was a problem hiding this comment.
One can build a query consisting of find() and filter() calls, where the QL for the filtering follows the QL of our filter_docs() function. I will put more information on this in the docstrings
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Co-authored-by: Alex Cureton-Griffiths <[email protected]> Signed-off-by: Charlotte Gerhaher <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
| def execute_query(self, query: List[Tuple[str, Dict]], *args, **kwargs) -> Any: | ||
| """ |
There was a problem hiding this comment.
this method has significant overlap with its counterpart in the hnswlib implementation. Do you think we can share that code somehow? either have helper methods somewhere, or through inheritance?
There was a problem hiding this comment.
i put it into a helper file in the backends dir
JohannesMessner
left a comment
There was a problem hiding this comment.
looks good! just some small things
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
Co-authored-by: Alex Cureton-Griffiths <[email protected]> Signed-off-by: Charlotte Gerhaher <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
alexcg1
left a comment
There was a problem hiding this comment.
Please only ask me to review after all feedback has been resolved 😅
Oops. My bad. I saw the notification and I assumed a review had been re-requested. Can ignore my prior comment |
Signed-off-by: anna-charlotte <[email protected]>
Signed-off-by: anna-charlotte <[email protected]>
|
this pr might fix this bug : #1445 |
|
📝 Docs are deployed on https://ft-feat-in-memory-doc-index--jina-docs.netlify.app 🎉 |
samsja
left a comment
There was a problem hiding this comment.
lets wait to merge it until we decide if it go into the next release or not
Add an in-memory DocIndex class