Skip to content

fix: fix dataframe max recursion depth #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoanFM wants to merge 2 commits into from
Closed

fix: fix dataframe max recursion depth #1464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c396538
fix: fix max recursion
Apr 27, 2023
b68a641
fix: fix recursion depth issue
Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docarray/base_doc/mixins/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,11 @@ def _get_access_paths(cls) -> List[str]:
paths = []
for field in cls.__fields__.keys():
field_type = cls._get_field_type(field)
if not is_union_type(field_type) and issubclass(field_type, BaseDoc):
if (
field != 'id'
and not is_union_type(field_type)
and issubclass(field_type, BaseDoc)
):
sub_paths = field_type._get_access_paths()
for path in sub_paths:
paths.append(f'{field}__{path}')
Expand Down
Empty file added tests/integrations/issues/__init__.py
View file
Open in desktop
Empty file.
23 changes: 23 additions & 0 deletions tests/integrations/issues/test_1463.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
from docarray import DocList, BaseDoc
from docarray.typing import NdArrayEmbedding
from docarray.utils.find import find

import numpy as np


def test_fix_max_recursion():
class Doc(BaseDoc):
text: str
embedding: NdArrayEmbedding

query = np.random.rand(128)
index = DocList[Doc](
[Doc(text=_, embedding=np.random.rand(128)) for _ in range(100)]
)
top_matches, _ = find(
index=index, query=query, search_field='embedding', metric='cosine_sim'
)
df = top_matches.to_dataframe()
assert 'id' in df.columns
assert 'embedding' in df.columns
assert 'text' in df.columns