Skip to content

refactor: remove useless step in json encoder #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 4 commits into from
May 8, 2023
Merged

refactor: remove useless step in json encoder #1513

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3ab971
fix: json and dict when calling empty doclist
samsja May 8, 2023
e85cd8c
tests: add more tests
samsja May 8, 2023
eda1aed
chore: add comments
samsja May 8, 2023
a466762
Merge branch 'main' into fix-empty-doc-list
samsja May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docarray/base_doc/doc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,9 @@ def json(
# we need to do this because pydantic will not recognize DocList correctly
original_exclude = original_exclude or {}
if field not in original_exclude:
val = getattr(self, field)
data[field] = [doc.dict() for doc in val] if val is not None else None
data[field] = getattr(
self, field
) # here we need to keep doclist as doclist otherwise if a user want to have a special json config it will not work

# this is copy from pydantic code
if self.__custom_root_type__:
Expand Down