Skip to content

refactor: split client config into separate parameters#155

Merged
hanxiao merged 3 commits intomainfrom
refactor-weaviate-client
Feb 28, 2022
Merged

refactor: split client config into separate parameters#155
hanxiao merged 3 commits intomainfrom
refactor-weaviate-client

Conversation

@alaeddine-13
Copy link
Copy Markdown
Member

refactor: split client config into separate parameters

Copy link
Copy Markdown
Contributor

@davidbp davidbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 28, 2022

Codecov Report

Merging #155 (defc65a) into main (f68fe7b) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   84.39%   84.45%   +0.06%     
==========================================
  Files         115      115              
  Lines        4985     4993       +8     
==========================================
+ Hits         4207     4217      +10     
+ Misses        778      776       -2     
Flag Coverage Δ
docarray 84.45% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/weaviate/backend.py 87.50% <100.00%> (+1.78%) ⬆️
docarray/array/storage/qdrant/helper.py 95.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f68fe7b...defc65a. Read the comment docs.

@github-actions
Copy link
Copy Markdown

📝 Docs are deployed on https://ft-refactor-weaviate-client--jina-docs.netlify.app 🎉

@hanxiao hanxiao merged commit 454fce0 into main Feb 28, 2022
@hanxiao hanxiao deleted the refactor-weaviate-client branch February 28, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants