Merged
Conversation
Member
|
Hello @punndcoder28, Thank you very much for the contribution. We need you to sign off the commits in the PR before we can merge the contribution. |
samsja
reviewed
Jun 13, 2023
Contributor
Author
|
Hi @samsja Thanks for the review. I have updated the doc with suggested changes. @JoanFM I have signed off the latest commit, will I have to do it for each and every commit in the PR. I tried to amend the commit last night to have the sign off message but couldn't since it was complaining that there were no changes to push. Should have tried to force push to the branch |
Contributor
Author
Signed-off-by: punndcoder28 <[email protected]>
b3bb7bb to
90d46b8
Compare
Contributor
Author
|
@samsja any updates on the timeline to review and merge this PR? |
JoanFM
approved these changes
Jul 5, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1560 by adding detailed doc for the
base_doc.dict()method describing how it is different from the python methoddict()