replace usage of issubclass with safe_issubclass in `BaseDocWitho…#1904
Merged
JoanFM merged 3 commits intodocarray:mainfrom Aug 17, 2024
yxtay:patch-1
Merged
replace usage of issubclass with safe_issubclass in `BaseDocWitho…#1904JoanFM merged 3 commits intodocarray:mainfrom yxtay:patch-1
issubclass with safe_issubclass in `BaseDocWitho…#1904JoanFM merged 3 commits intodocarray:mainfrom
yxtay:patch-1
Conversation
…utId` Signed-off-by: YuXuan Tay <[email protected]>
JoanFM
approved these changes
Aug 14, 2024
Member
|
Hey @yxtay, I would need you to sign off the commits for the PR to be merged. |
Contributor
Author
|
Hi @JoanFM, I have amended and signed the commits. Please let me know if any other action is required. |
Member
|
I am currently away from device, but I will check the test errors once I am back |
Contributor
Author
|
It looks like many of the failures are due to usage of I have created a PR #1905 |
Signed-off-by: YuXuan Tay <[email protected]>
Member
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issubclasswithsafe_issubclassinBaseDocWithoutIDandMilvusDocumentIndexissubclassare insafe_issubclassfunction and tests onlyFixes #1903