Conversation
…elastic-storage
…elastic-storage
numb3r3
suggested changes
Mar 16, 2022
numb3r3
suggested changes
Mar 25, 2022
| if _docs is None: | ||
| return | ||
| elif isinstance( | ||
| _docs, (DocumentArray, Sequence, Generator, Iterator, itertools.chain) |
Contributor
There was a problem hiding this comment.
if isinstance(docs, Iterable) and self._ref_doc is not None: is good enough here.
Contributor
Author
There was a problem hiding this comment.
This would allow other iterables that are not supported? I leave it as is, which is how it is done in other storage backends.
Contributor
There was a problem hiding this comment.
Please check the latest main, this is the current implementation in other storage
numb3r3
suggested changes
Mar 28, 2022
| if _docs is None: | ||
| return | ||
| elif isinstance( | ||
| _docs, (DocumentArray, Sequence, Generator, Iterator, itertools.chain) |
Contributor
There was a problem hiding this comment.
Please check the latest main, this is the current implementation in other storage
numb3r3
approved these changes
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.