Conversation
Codecov Report
@@ Coverage Diff @@
## main #371 +/- ##
==========================================
- Coverage 86.53% 83.52% -3.01%
==========================================
Files 134 136 +2
Lines 6704 6726 +22
==========================================
- Hits 5801 5618 -183
- Misses 903 1108 +205
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@alaeddine-13 please take care of this PR thanks, we have to move forward. It doesn't make sense to be blocked by paddle because of the lack of maintenance on their side. Please refactor the tests, or in the worst case, remove paddle tests (or even functions). Move this PR forward at any cost. Ref: https://jinaai.slack.com/archives/C02AC4T8Y5T/p1661117495528849 |
|
we're proceeding like so:
|
docarray/proto/__init__.py
Outdated
| @@ -0,0 +1,12 @@ | |||
| from google.protobuf import __version__ as __pb__version__ | |||
|
|
|||
| if __pb__version__.startswith('4'): | |||
I agree on this |
|
i haven't looked at the protobuf docs generation, is it affected? |
closes: #376