feat: push meta data along with docarray 0.16#490
Conversation
Codecov Report
@@ Coverage Diff @@
## main #490 +/- ##
==========================================
+ Coverage 84.47% 86.40% +1.93%
==========================================
Files 142 142
Lines 7087 7137 +50
==========================================
+ Hits 5987 6167 +180
+ Misses 1100 970 -130
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| da = da_cls.empty(100) | ||
| da._get_attributes() | ||
| da.summary() | ||
| da._get_raw_summary() |
There was a problem hiding this comment.
unlike summary, I think here the output can be tested
JohannesMessner
left a comment
There was a problem hiding this comment.
Some documentation would be nice!
docarray/array/mixins/io/pushpull.py
Outdated
|
|
||
| @classmethod | ||
| @hubble.login_required | ||
| def cloud_list(cls, show_table: bool = False) -> List[str]: |
There was a problem hiding this comment.
Am I understanding correctly that the intended usage is to do DocumentArray.cloud_list() (same for cloud_delete())?
I am not sure if it is super intuitive to the user to interact with the DocumentArray class when what they are doing is communicating with a server. In my head this operation has not much to do with DocumentArray.
Could this be just a function that the user imports directly?
There was a problem hiding this comment.
I think static method looks more comprehensive
There was a problem hiding this comment.
I think it is better to be a staticmethod and not a classmethod. You do not use cls for anything right?
|
Please hold your review on this PR, there is no point in thinking too much about this PR until we get the Hub UI out. All other work is overengineering. In other words, we need to get first version of Hub UI this PR merged, before make meaningful progress. |
18e130c to
7b008c1
Compare
documentation added |
docarray/array/mixins/io/pushpull.py
Outdated
|
|
||
| @classmethod | ||
| @hubble.login_required | ||
| def cloud_list(cls, show_table: bool = False) -> List[str]: |
There was a problem hiding this comment.
I think it is better to be a staticmethod and not a classmethod. You do not use cls for anything right?
|
📝 Docs are deployed on https://ft-feat-push-metadata--jina-docs.netlify.app 🎉 |
Note: Please hold your review on this PR, there is no point in thinking too much about this PR until we get the Hub UI out, otherwise it is overengineering. In other words, we need to get first version of Hub UI this PR merged, before make meaningful progress.
leverage hubble
metaDatafield and upload meta informatio, so that the Console Data GUI is able to show preview info directly.metaDatais containsbrandingandsummaryfield,brandingis a dict containsiconandbackground, i.e. emoji + background colorsummaryis similar to the data contains in https://docarray.jina.ai/fundamentals/documentarray/visualization/?highlight=summary#summary-in-table (note docs screenshot isn't complete)use
print(DocumentArray.empty(10).push('your-name-12345'))to see the full payload