fix: update offset2id when deleting in subindex#496
Merged
JohannesMessner merged 2 commits intomainfrom Aug 23, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #496 +/- ##
==========================================
- Coverage 86.51% 85.49% -1.03%
==========================================
Files 134 134
Lines 6698 6702 +4
==========================================
- Hits 5795 5730 -65
- Misses 903 972 +69
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
Author
|
@AnneYang720 this is a PR for your suggestion, thanks! |
alaeddine-13
approved these changes
Aug 23, 2022
samsja
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
make sure that
offset2idsis correctly updated when deleting in a subindex.Previously, the call to
del_docs_by_ids()did not do it, but usingdeldoes it under the hood.