feat: columns should be a dictionary not list of tuples#526
Merged
Conversation
6944958 to
45825aa
Compare
Member
Author
|
Linked to jina-ai/annlite#160 |
Codecov Report
@@ Coverage Diff @@
## main #526 +/- ##
==========================================
- Coverage 86.26% 86.24% -0.03%
==========================================
Files 142 142
Lines 7033 7036 +3
==========================================
+ Hits 6067 6068 +1
- Misses 966 968 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
7572c47 to
01f680c
Compare
JoanFM
commented
Sep 6, 2022
Co-authored-by: Johannes Messner <[email protected]>
455db8e to
bb832ef
Compare
bb832ef to
baca7b4
Compare
numb3r3
previously requested changes
Sep 8, 2022
12fc506 to
a9bd405
Compare
a9bd405 to
cd53950
Compare
49803f3 to
c8a3528
Compare
c8a3528 to
61d2a29
Compare
alaeddine-13
reviewed
Sep 8, 2022
1d22bab to
ae827eb
Compare
alaeddine-13
reviewed
Sep 8, 2022
60d1016 to
3a57cc1
Compare
|
📝 Docs are deployed on https://ft-columns-as-dict--jina-docs.netlify.app 🎉 |
alaeddine-13
approved these changes
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
Since List[Tuple] is not something that can be passed via YAML to a Flow, we need to make sure that this is doable, so having a
Dictlike structure forcolumnsis the best way to go.