Skip to content

fix: keep out of mask docs in del by mask #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 2 commits into from
Sep 9, 2022
Merged

fix: keep out of mask docs in del by mask #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c372403
fix: keep out of mask docs
alaeddine-13 Sep 9, 2022
1626e2b
test: assert ids are kept
alaeddine-13 Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docarray/array/storage/memory/getsetdel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ class GetSetDelMixin(BaseGetSetDelMixin):

@needs_id2offset_rebuild
def _del_docs_by_mask(self, mask: Sequence[bool]):
if len(mask) < len(self._data):
mask = mask + [False for _ in range(len(self._data) - len(mask))]
self._data = list(itertools.compress(self._data, (not _i for _i in mask)))

@needs_id2offset_rebuild
Expand Down
4 changes: 3 additions & 1 deletion tests/unit/array/mixins/test_del.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def test_del_all(docs, to_delete):
],
)
def test_del_boolean_mask(docs, to_delete, missing_id):

all_ids = docs[:, 'id']
# assert each missing_id is present before deleting
for m_id in missing_id:
assert m_id in docs[:, 'id']
Expand All @@ -52,6 +52,8 @@ def test_del_boolean_mask(docs, to_delete, missing_id):
# assert each missing_id is NOT present AFTER deleting
for m_id in missing_id:
assert m_id not in docs[:, 'id']
for m_id in filter(lambda id: id not in missing_id, all_ids):
assert m_id in docs[:, 'id']


@pytest.mark.parametrize(
Expand Down