feat(redis): add full-text search and io#535
Merged
bwanglzu merged 11 commits intodocarray:mainfrom Sep 14, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #535 +/- ##
==========================================
- Coverage 86.25% 84.47% -1.78%
==========================================
Files 142 142
Lines 7050 7087 +37
==========================================
- Hits 6081 5987 -94
- Misses 969 1100 +131
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bwanglzu
suggested changes
Sep 12, 2022
| # (DocumentArrayAnnlite, PqliteConfig(n_dim=3)), # TODO: enable this | ||
| # (DocumentArrayQdrant, QdrantConfig(n_dim=3)), | ||
| # (DocumentArrayElastic, ElasticConfig(n_dim=3)), # Elastic needs config | ||
| # (DocumentArrayRedis, RedisConfig(n_dim=3, flush=True)), # Redis needs config |
Contributor
Author
There was a problem hiding this comment.
Annlite, Qdrant and Elastic were already commented. I think Redis is the same as Elastic that they both need a non-empty config, so they cannot use from_base64
|
make sure the BM25 and TF-IDF is documented |
bwanglzu
reviewed
Sep 13, 2022
bwanglzu
reviewed
Sep 13, 2022
Member
alaeddine-13
left a comment
There was a problem hiding this comment.
it would be great if we also test scorer. We probably will not test the scoring itself but we can check that using the parameter doesn't break anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
This PR will add support of full-text search in redis according to #500 and add io functions in redis.