Skip to content

feat: login required push pull#541

Merged
alaeddine-13 merged 4 commits intomainfrom
feat-login-required-push-pull
Sep 19, 2022
Merged

feat: login required push pull#541
alaeddine-13 merged 4 commits intomainfrom
feat-login-required-push-pull

Conversation

@alaeddine-13
Copy link
Copy Markdown
Member

Enforce login on DocumentArray.push/pull using hubble.login_required

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 16, 2022

Codecov Report

Merging #541 (50b0a8b) into main (5693b3a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   86.40%   86.44%   +0.03%     
==========================================
  Files         142      142              
  Lines        7137     7141       +4     
==========================================
+ Hits         6167     6173       +6     
+ Misses        970      968       -2     
Flag Coverage Δ
docarray 86.44% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/mixins/io/pushpull.py 92.43% <100.00%> (+0.26%) ⬆️
docarray/helper.py 83.46% <0.00%> (+0.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alaeddine-13 alaeddine-13 force-pushed the feat-login-required-push-pull branch from 420964a to 44ead1e Compare September 16, 2022 15:17
Copy link
Copy Markdown
Member

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alaeddine-13 alaeddine-13 marked this pull request as ready for review September 19, 2022 08:14
@alaeddine-13 alaeddine-13 merged commit b2ca490 into main Sep 19, 2022
@alaeddine-13 alaeddine-13 deleted the feat-login-required-push-pull branch September 19, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants