Skip to content

fix: adapt to annlite changes#543

Merged
alaeddine-13 merged 1 commit intomainfrom
fix-annlite-search-vectors
Sep 19, 2022
Merged

fix: adapt to annlite changes#543
alaeddine-13 merged 1 commit intomainfrom
fix-annlite-search-vectors

Conversation

@alaeddine-13
Copy link
Copy Markdown
Member

annlite in 0.3.12, renames private method _search_documents which was used by docarray and makes it a public method.
Therefore, we correct the method name in docarray

Copy link
Copy Markdown
Contributor

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 19, 2022

Codecov Report

Merging #543 (4bf1fdf) into main (14526db) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files         142      142           
  Lines        7137     7137           
=======================================
  Hits         6167     6167           
  Misses        970      970           
Flag Coverage Δ
docarray 86.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/annlite/find.py 93.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alaeddine-13 alaeddine-13 merged commit 5693b3a into main Sep 19, 2022
@alaeddine-13 alaeddine-13 deleted the fix-annlite-search-vectors branch September 19, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants