Codecov Report

Merging #556 (a4ad460) into main (4764cc7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   86.41%   86.39%   -0.02%     
==========================================
  Files         142      134       -8     
  Lines        7139     6718     -421     
==========================================
- Hits         6169     5804     -365     
+ Misses        970      914      -56     

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This looks good. Thanks for the quick turn around! Do you think a try/exception statement would help with error handling? I.e. #549

Hey @TEChopra1000,

This should not affect, since the Exceptions should be directly raised.

What if someone want to change a parameters from another function that is called inside this one ?

In this pr we only assume that user would only want to change urllib.request.urlopen parameters but why not could he want to change req = urllib.request.Request as well for instance ?

What if someone want to change a parameters from another function that is called inside this one ?

In this pr we only assume that user would only want to change urllib.request.urlopen parameters but why not could he want to change req = urllib.request.Request as well for instance ?

Do you suggest simply to add timeout to _uri_to_blob but keep **kwargs in the API public functions?