fix: keep redis default values for vector similarity parameters#559
Merged
alaeddine-13 merged 2 commits intomainfrom Sep 23, 2022
Merged
fix: keep redis default values for vector similarity parameters#559alaeddine-13 merged 2 commits intomainfrom
alaeddine-13 merged 2 commits intomainfrom
Conversation
JoanFM
approved these changes
Sep 23, 2022
samsja
approved these changes
Sep 23, 2022
Member
samsja
left a comment
There was a problem hiding this comment.
lgtm
I really like this pattern we should always use it as well when passing kwargs to other function
Codecov Report
@@ Coverage Diff @@
## main #559 +/- ##
=======================================
Coverage 86.39% 86.39%
=======================================
Files 134 134
Lines 6718 6718
=======================================
Hits 5804 5804
Misses 914 914
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
fyi @AnneYang720 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #557
Avoid introducing new default values for vector similarity configuration in redis backend, rather use None and leave it up to the database to decide the default value.