Skip to content

fix: remove check of default value in _non_empty_fields #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 2 commits into from
Sep 27, 2022
Merged

fix: remove check of default value in _non_empty_fields #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27b5dd6
refactor: remove check of default value in _non_empty_fields
guenthermi Sep 26, 2022
eb3d4da
test: add test for string representation of named scores
guenthermi Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions docarray/score/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,7 @@ def _non_empty_fields(self) -> Tuple[str]:
if not f_name.startswith('_'):
v = getattr(self, f_name)
if v is not None:
if f_name not in default_values:
r.append(f_name)
else:
dv = default_values[f_name]
if v != dv:
r.append(f_name)
r.append(f_name)

return tuple(r)

Expand Down
7 changes: 7 additions & 0 deletions tests/unit/test_named_score.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
from docarray.score import NamedScore


def test_str_representation():
assert str(NamedScore(value=0.0)) == str({'value': 0.0})
assert str(NamedScore(value=None)) == str(dict())
assert str(NamedScore(value=0.3)) == str({'value': 0.3})