Skip to content

feat: redis supports geo filter#579

Merged
JoanFM merged 11 commits intodocarray:mainfrom
AnneYang720:feat-redis-geo
Oct 19, 2022
Merged

feat: redis supports geo filter#579
JoanFM merged 11 commits intodocarray:mainfrom
AnneYang720:feat-redis-geo

Conversation

@AnneYang720
Copy link
Copy Markdown
Contributor

@AnneYang720 AnneYang720 commented Sep 29, 2022

Goals:

This PR will add support for using geo filter in Redis storage backend.

  • add redis geo field to typemap
  • update related test
  • update documentation

@AnneYang720 AnneYang720 marked this pull request as draft September 29, 2022 08:26
@JoanFM
Copy link
Copy Markdown
Member

JoanFM commented Sep 29, 2022

Hey @AnneYang720 ,

can u please add in the description of an example of how people would interact with this feature?

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 29, 2022

Codecov Report

Merging #579 (946bb66) into main (135c007) will decrease coverage by 3.61%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
- Coverage   86.45%   82.84%   -3.62%     
==========================================
  Files         133      133              
  Lines        6755     6755              
==========================================
- Hits         5840     5596     -244     
- Misses        915     1159     +244     
Flag Coverage Δ
docarray 82.84% <100.00%> (-3.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/redis/find.py 86.36% <ø> (ø)
docarray/array/storage/redis/backend.py 92.30% <100.00%> (-4.28%) ⬇️
docarray/array/mixins/embed.py 10.52% <0.00%> (-78.95%) ⬇️
docarray/array/mixins/io/pushpull.py 32.78% <0.00%> (-59.02%) ⬇️
docarray/array/mixins/io/dataframe.py 40.00% <0.00%> (-46.67%) ⬇️
docarray/array/mixins/io/common.py 28.57% <0.00%> (-38.10%) ⬇️
docarray/array/mixins/io/json.py 67.64% <0.00%> (-23.53%) ⬇️
docarray/array/mixins/group.py 70.00% <0.00%> (-17.50%) ⬇️
docarray/array/storage/annlite/backend.py 82.66% <0.00%> (-13.34%) ⬇️
docarray/array/storage/sqlite/backend.py 84.61% <0.00%> (-8.98%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AnneYang720 AnneYang720 marked this pull request as ready for review October 19, 2022 12:27
@JoanFM JoanFM requested a review from NicholasDunham October 19, 2022 13:53
@JoanFM JoanFM merged commit 5d06133 into docarray:main Oct 19, 2022
dongxiang123 pushed a commit that referenced this pull request Oct 20, 2022
dongxiang123 pushed a commit that referenced this pull request Oct 20, 2022
dongxiang123 pushed a commit that referenced this pull request Oct 20, 2022
dongxiang123 pushed a commit that referenced this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants